Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong issue position when create a quick issue on a rotated shape #5162

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fixed wrong issue position when create a quick issue on a rotated shape #5162

merged 2 commits into from
Oct 25, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 25, 2022 •
edited
Loading

Motivation and context

Resolved #4379

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Fixed wrong issue position when create a quick issue on a rotated shape Fixed wrong issue position when create a quick issue on a rotated shape Oct 25, 2022
@bsekachev
Copy link
Member Author

@klakhov

Can you check this one? In general I just pulled some code from a condition.

@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@klakhov klakhov self-assigned this Oct 25, 2022
klakhov
klakhov approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is solved 😄

@bsekachev bsekachev merged commit 0b12a77 into develop Oct 25, 2022
@bsekachev bsekachev deleted the bs/fixed_issue_4379 branch October 25, 2022 17:34
rhee-elten pushed a commit to rhee-elten/cvat that referenced this pull request Oct 26, 2022
@bsekachev @rhee-elten
Fixed wrong issue position when create a quick issue on a rotated sha…
3934fa8 
…pe (cvat-ai#5162)

* Fixed wrong issue position when create a quick issue on a rotated shape

* Updated changelog
@nmanovic nmanovic mentioned this pull request Nov 1, 2022
Closed
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees

@klakhov klakhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue box rotation is not applied on rotated rectangles
2 participants
@bsekachev @klakhov